From b072cfc7ce5758f2009c8bbe791af7519dd9aa61 Mon Sep 17 00:00:00 2001 From: Marcel Date: Sun, 17 Oct 2021 10:45:24 +0200 Subject: [PATCH] fixed security hotspots & code smells --- .../adapter/out/web/PublishNewTaskEventAdapter.java | 6 +++++- .../adapter/out/web/PublishTaskCompletedEventAdapter.java | 6 +++++- .../java/ch/unisg/assignment/assignment/domain/Task.java | 2 +- .../assignment/domain/event/TaskAssignedEvent.java | 2 +- 4 files changed, 12 insertions(+), 4 deletions(-) diff --git a/assignment/src/main/java/ch/unisg/assignment/assignment/adapter/out/web/PublishNewTaskEventAdapter.java b/assignment/src/main/java/ch/unisg/assignment/assignment/adapter/out/web/PublishNewTaskEventAdapter.java index b764faa..1db2b84 100644 --- a/assignment/src/main/java/ch/unisg/assignment/assignment/adapter/out/web/PublishNewTaskEventAdapter.java +++ b/assignment/src/main/java/ch/unisg/assignment/assignment/adapter/out/web/PublishNewTaskEventAdapter.java @@ -5,6 +5,8 @@ import java.net.URI; import java.net.http.HttpClient; import java.net.http.HttpRequest; import java.net.http.HttpResponse; +import java.util.logging.Level; +import java.util.logging.Logger; import org.springframework.context.annotation.Primary; import org.springframework.stereotype.Component; @@ -18,6 +20,8 @@ public class PublishNewTaskEventAdapter implements NewTaskEventPort { String server = "http://127.0.0.1:8085"; + Logger logger = Logger.getLogger(PublishNewTaskEventAdapter.class.getName()); + @Override public void publishNewTaskEvent(NewTaskEvent event) { @@ -31,7 +35,7 @@ public class PublishNewTaskEventAdapter implements NewTaskEventPort { try { client.send(request, HttpResponse.BodyHandlers.ofString()); } catch (IOException | InterruptedException e) { - e.printStackTrace(); + logger.log(Level.SEVERE, e.getLocalizedMessage(), e); // Restore interrupted state... Thread.currentThread().interrupt(); } diff --git a/assignment/src/main/java/ch/unisg/assignment/assignment/adapter/out/web/PublishTaskCompletedEventAdapter.java b/assignment/src/main/java/ch/unisg/assignment/assignment/adapter/out/web/PublishTaskCompletedEventAdapter.java index 59a27ce..f9f2833 100644 --- a/assignment/src/main/java/ch/unisg/assignment/assignment/adapter/out/web/PublishTaskCompletedEventAdapter.java +++ b/assignment/src/main/java/ch/unisg/assignment/assignment/adapter/out/web/PublishTaskCompletedEventAdapter.java @@ -5,6 +5,8 @@ import java.net.URI; import java.net.http.HttpClient; import java.net.http.HttpRequest; import java.net.http.HttpResponse; +import java.util.logging.Level; +import java.util.logging.Logger; import org.json.JSONObject; import org.springframework.context.annotation.Primary; @@ -19,6 +21,8 @@ public class PublishTaskCompletedEventAdapter implements TaskCompletedEventPort String server = "http://127.0.0.1:8081"; + Logger logger = Logger.getLogger(PublishTaskCompletedEventAdapter.class.getName()); + @Override public void publishTaskCompleted(TaskCompletedEvent event) { @@ -39,7 +43,7 @@ public class PublishTaskCompletedEventAdapter implements TaskCompletedEventPort try { client.send(request, HttpResponse.BodyHandlers.ofString()); } catch (IOException | InterruptedException e) { - e.printStackTrace(); + logger.log(Level.SEVERE, e.getLocalizedMessage(), e); // Restore interrupted state... Thread.currentThread().interrupt(); } diff --git a/assignment/src/main/java/ch/unisg/assignment/assignment/domain/Task.java b/assignment/src/main/java/ch/unisg/assignment/assignment/domain/Task.java index 55fb00d..7daa738 100644 --- a/assignment/src/main/java/ch/unisg/assignment/assignment/domain/Task.java +++ b/assignment/src/main/java/ch/unisg/assignment/assignment/domain/Task.java @@ -30,6 +30,6 @@ public class Task { this.taskType = taskType; } - public Task() {}; + public Task() {} } diff --git a/assignment/src/main/java/ch/unisg/assignment/assignment/domain/event/TaskAssignedEvent.java b/assignment/src/main/java/ch/unisg/assignment/assignment/domain/event/TaskAssignedEvent.java index ef20f43..d0178d4 100644 --- a/assignment/src/main/java/ch/unisg/assignment/assignment/domain/event/TaskAssignedEvent.java +++ b/assignment/src/main/java/ch/unisg/assignment/assignment/domain/event/TaskAssignedEvent.java @@ -1,7 +1,7 @@ package ch.unisg.assignment.assignment.domain.event; public class TaskAssignedEvent { - public String taskID; + public final String taskID; public TaskAssignedEvent(String taskID) { this.taskID = taskID;