maece/HSG-MCS-HS21_tapas
1
0
Fork 0
Code Issues 14 Pull Requests Packages Projects Releases 6 Wiki Activity

Implemented RemovedEventListener... #51

Merged
rahimiankeanu merged 3 commits from ExecutorRemovedEventListenerMqttAdapter into dev 2021-11-14 15:12:10 +00:00
Conversation 1 Commits 3 Files Changed 3 +68 -1
rahimiankeanu commented 2021-11-07 22:38:38 +00:00 (Migrated from github.com)
Copy Link
No description provided.
Maece97 commented 2021-11-08 12:36:37 +00:00 (Migrated from github.com)
Copy Link

The post mapping annotations are missing for the handleExecutorRemovedEvent function. Please add them as well.

We also need to implement the mqtt executorRemovedEvent adapter as described in task #45

The post mapping annotations are missing for the handleExecutorRemovedEvent function. Please add them as well. We also need to implement the mqtt executorRemovedEvent adapter as described in task #45
reynisson (Migrated from github.com) approved these changes 2021-11-14 15:11:52 +00:00
tapas-auction-house/src/main/java/ch/unisg/tapas/auctionhouse/application/handler/ExecutorRemovedHandler.java
@ -17,2 +17,4 @@
return ExecutorRegistry.getInstance().removeExecutor(executorRemovedEvent.getExecutorId());
}
public void handleNewExecutorEvent(ExecutorRemovedEvent executorRemovedEvent) {
reynisson (Migrated from github.com) commented 2021-11-12 12:42:25 +00:00
Copy Link

I don't think we need to handle a New Executor event inside the ExecutorRemovedHandler

I don't think we need to handle a New Executor event inside the ExecutorRemovedHandler
Sign in to join this conversation.
Reviewers
No reviewers
reynisson
Labels
Clear labels   
auction house

   
bug

Something isn't working

  
computation executor

   
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
executor base

   
executor pool

   
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
robot executor

   
roster

   
task list

   
wontfix

This will not be worked on

No Label
auction house
bug
computation executor
documentation
duplicate
enhancement
executor base
executor pool
good first issue
help wanted
invalid
question
robot executor
roster
task list
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: maece/HSG-MCS-HS21_tapas#51
No description provided.
Delete Branch "ExecutorRemovedEventListenerMqttAdapter"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?