maece/HSG-MCS-HS21_tapas
1
0
Fork 0
Code Issues 14 Pull Requests Packages Projects Releases 6 Wiki Activity

Roster tests #88

New Issue
Closed
opened 2021-11-23 21:35:30 +00:00 by reynisson · 0 comments
reynisson commented 2021-11-23 21:35:30 +00:00 (Migrated from github.com)
Copy Link

You can find the examples I refer to from the task list under ch.unisg.tapastasks.tasks

Unit tests:

  • Test the adding of assignments (assignTaskToExecutor) to the rosterMap in the Roster
  • Ensure the assignment is added to the rosterMap, that the correct task is returned, and that the task is removed from the queues (See TaskListTest in ch.unisg.tapastasks.tasks.domain for inspiration)
  • To do so you need to implement a getter for the rosterMap and queues that returns the rosterItems and tasks respectively. See for example getAllAuctions in AuctionRegistry in Auction House.
  • Test the assignment of tasks via the ApplyForTaskService similar to how AddNewTaskToTaskListServiceTest tests the AddNewTaskToTaskListService. Note: the roster does not have a lock like the task list has the TaskListLock. So this does not need to be tested in the roster

Integration tests:

  • Test the assignment of tasks via the ApplyForTaskController, similar to how AddNewTaskToTaskListWebControllerTest tests the AddNewTaskToTaskListWebController.
  • Test the RosterPersistanceAdapter similar to how the TaskPersistenceAdapterTest tests the TaskPersistenceAdapter

System tests:

  • Fully test the assignment to tasks, similar to how the AddNewTaskToTaskListSystemTest tests the adding of tasks to the task list
You can find the examples I refer to from the task list under ch.unisg.tapastasks.tasks Unit tests: - [x] Test the adding of assignments (assignTaskToExecutor) to the rosterMap in the Roster - [x] Ensure the assignment is added to the rosterMap, that the correct task is returned, and that the task is removed from the queues (See TaskListTest in ch.unisg.tapastasks.tasks.domain for inspiration) - [x] To do so you need to implement a getter for the rosterMap and queues that returns the rosterItems and tasks respectively. See for example getAllAuctions in AuctionRegistry in Auction House. - [x] Test the assignment of tasks via the ApplyForTaskService similar to how AddNewTaskToTaskListServiceTest tests the AddNewTaskToTaskListService. Note: the roster does not have a lock like the task list has the TaskListLock. So this does not need to be tested in the roster Integration tests: - [x] Test the assignment of tasks via the ApplyForTaskController, similar to how AddNewTaskToTaskListWebControllerTest tests the AddNewTaskToTaskListWebController. - [x] Test the RosterPersistanceAdapter similar to how the TaskPersistenceAdapterTest tests the TaskPersistenceAdapter System tests: - [x] Fully test the assignment to tasks, similar to how the AddNewTaskToTaskListSystemTest tests the adding of tasks to the task list
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
auction house
bug
Something isn't working
computation executor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
executor base
executor pool
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
robot executor
roster
task list
wontfix
This will not be worked on
No Label
roster
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
maece
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: maece/HSG-MCS-HS21_tapas#88
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?