maece/HSG-MCS-HS21_tapas
1
0
Fork 0
Code Issues 14 Pull Requests Packages Projects Releases 6 Wiki Activity

added unit tests for the roster #89

Merged
julius-lautz merged 37 commits from roster_tests into dev 2021-11-28 23:26:38 +00:00
Conversation 5 Commits 37 Files Changed 86 +3444 -345
julius-lautz commented 2021-11-25 10:09:29 +00:00 (Migrated from github.com)
Copy Link
No description provided.
sonarcloud[bot] commented 2021-11-28 23:17:59 +00:00 (Migrated from github.com)
Copy Link

[roster] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 16 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

[**roster**] Kudos, SonarCloud Quality Gate passed!    ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed') [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-assignment&pullRequest=89&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-assignment&pullRequest=89&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-assignment&pullRequest=89&resolved=false&types=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-assignment&pullRequest=89&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-assignment&pullRequest=89&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-assignment&pullRequest=89&resolved=false&types=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=scs-asse-fs21-group1_tapas-assignment&pullRequest=89&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=scs-asse-fs21-group1_tapas-assignment&pullRequest=89&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=scs-asse-fs21-group1_tapas-assignment&pullRequest=89&resolved=false&types=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-assignment&pullRequest=89&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-assignment&pullRequest=89&resolved=false&types=CODE_SMELL) [16 Code Smells](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-assignment&pullRequest=89&resolved=false&types=CODE_SMELL) [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=scs-asse-fs21-group1_tapas-assignment&pullRequest=89&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=scs-asse-fs21-group1_tapas-assignment&pullRequest=89&metric=new_coverage&view=list) [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=scs-asse-fs21-group1_tapas-assignment&pullRequest=89&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=scs-asse-fs21-group1_tapas-assignment&pullRequest=89&metric=new_duplicated_lines_density&view=list)
reynisson (Migrated from github.com) approved these changes 2021-11-28 23:21:19 +00:00
roster/src/main/java/ch/unisg/roster/RosterApplication.java
@ -29,3 +29,3 @@
private static final LoadRosterItemPort loadRosterItemPort;
private static LoadRosterItemPort loadRosterItemPort;
public static void main(String[] args) {
reynisson (Migrated from github.com) commented 2021-11-25 10:13:35 +00:00
Copy Link

Let's make sure this is needed

Let's make sure this is needed
sonarcloud[bot] commented 2021-11-28 23:26:01 +00:00 (Migrated from github.com)
Copy Link

[executor-pool] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

[**executor-pool**] Kudos, SonarCloud Quality Gate passed!    ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed') [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-executor-pool&pullRequest=89&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-executor-pool&pullRequest=89&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-executor-pool&pullRequest=89&resolved=false&types=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-executor-pool&pullRequest=89&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-executor-pool&pullRequest=89&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-executor-pool&pullRequest=89&resolved=false&types=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=scs-asse-fs21-group1_tapas-executor-pool&pullRequest=89&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=scs-asse-fs21-group1_tapas-executor-pool&pullRequest=89&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=scs-asse-fs21-group1_tapas-executor-pool&pullRequest=89&resolved=false&types=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-executor-pool&pullRequest=89&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-executor-pool&pullRequest=89&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-executor-pool&pullRequest=89&resolved=false&types=CODE_SMELL) [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=scs-asse-fs21-group1_tapas-executor-pool&pullRequest=89&metric=coverage&view=list) No Coverage information [![No Duplication information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png 'No Duplication information')](https://sonarcloud.io/component_measures?id=scs-asse-fs21-group1_tapas-executor-pool&pullRequest=89&metric=duplicated_lines_density&view=list) No Duplication information
sonarcloud[bot] commented 2021-11-28 23:26:17 +00:00 (Migrated from github.com)
Copy Link

[executor-computation] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

[**executor-computation**] Kudos, SonarCloud Quality Gate passed!    ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed') [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-executor2&pullRequest=89&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-executor2&pullRequest=89&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-executor2&pullRequest=89&resolved=false&types=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-executor2&pullRequest=89&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-executor2&pullRequest=89&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-executor2&pullRequest=89&resolved=false&types=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=scs-asse-fs21-group1_tapas-executor2&pullRequest=89&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=scs-asse-fs21-group1_tapas-executor2&pullRequest=89&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=scs-asse-fs21-group1_tapas-executor2&pullRequest=89&resolved=false&types=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-executor2&pullRequest=89&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-executor2&pullRequest=89&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-executor2&pullRequest=89&resolved=false&types=CODE_SMELL) [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=scs-asse-fs21-group1_tapas-executor2&pullRequest=89&metric=coverage&view=list) No Coverage information [![No Duplication information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png 'No Duplication information')](https://sonarcloud.io/component_measures?id=scs-asse-fs21-group1_tapas-executor2&pullRequest=89&metric=duplicated_lines_density&view=list) No Duplication information
sonarcloud[bot] commented 2021-11-28 23:26:18 +00:00 (Migrated from github.com)
Copy Link

[executor-robot] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

[**executor-robot**] Kudos, SonarCloud Quality Gate passed!    ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed') [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-executor1&pullRequest=89&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-executor1&pullRequest=89&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-executor1&pullRequest=89&resolved=false&types=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-executor1&pullRequest=89&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-executor1&pullRequest=89&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-executor1&pullRequest=89&resolved=false&types=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=scs-asse-fs21-group1_tapas-executor1&pullRequest=89&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=scs-asse-fs21-group1_tapas-executor1&pullRequest=89&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=scs-asse-fs21-group1_tapas-executor1&pullRequest=89&resolved=false&types=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-executor1&pullRequest=89&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-executor1&pullRequest=89&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-executor1&pullRequest=89&resolved=false&types=CODE_SMELL) [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=scs-asse-fs21-group1_tapas-executor1&pullRequest=89&metric=coverage&view=list) No Coverage information [![No Duplication information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png 'No Duplication information')](https://sonarcloud.io/component_measures?id=scs-asse-fs21-group1_tapas-executor1&pullRequest=89&metric=duplicated_lines_density&view=list) No Duplication information
sonarcloud[bot] commented 2021-11-28 23:26:23 +00:00 (Migrated from github.com)
Copy Link

[tapas-tasks] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

[**tapas-tasks**] Kudos, SonarCloud Quality Gate passed!    ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed') [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-tasks&pullRequest=89&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-tasks&pullRequest=89&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-tasks&pullRequest=89&resolved=false&types=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-tasks&pullRequest=89&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-tasks&pullRequest=89&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-tasks&pullRequest=89&resolved=false&types=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=scs-asse-fs21-group1_tapas-tasks&pullRequest=89&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=scs-asse-fs21-group1_tapas-tasks&pullRequest=89&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=scs-asse-fs21-group1_tapas-tasks&pullRequest=89&resolved=false&types=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-tasks&pullRequest=89&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-tasks&pullRequest=89&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=scs-asse-fs21-group1_tapas-tasks&pullRequest=89&resolved=false&types=CODE_SMELL) [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=scs-asse-fs21-group1_tapas-tasks&pullRequest=89&metric=coverage&view=list) No Coverage information [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=scs-asse-fs21-group1_tapas-tasks&pullRequest=89&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=scs-asse-fs21-group1_tapas-tasks&pullRequest=89&metric=new_duplicated_lines_density&view=list)
reynisson (Migrated from github.com) approved these changes 2021-11-28 23:26:30 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
reynisson
Labels
Clear labels   
auction house

   
bug

Something isn't working

  
computation executor

   
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
executor base

   
executor pool

   
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
robot executor

   
roster

   
task list

   
wontfix

This will not be worked on

No Label
auction house
bug
computation executor
documentation
duplicate
enhancement
executor base
executor pool
good first issue
help wanted
invalid
question
robot executor
roster
task list
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: maece/HSG-MCS-HS21_tapas#89
No description provided.
Delete Branch "roster_tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?