Auctionhouse websub #63

Merged
Maece97 merged 5 commits from auctionhouse-websub into dev 2021-11-14 21:16:15 +00:00
Showing only changes of commit 613c1482d7 - Show all commits

View File

@ -17,7 +17,7 @@ public class ValidateIntentWebSubAdapter {
reynisson commented 2021-11-14 19:50:49 +00:00 (Migrated from github.com)
Review

Isn't the naming here a bit weird?

Isn't the naming here a bit weird?
reynisson commented 2021-11-14 19:50:49 +00:00 (Migrated from github.com)
Review

Isn't the naming here a bit weird?

Isn't the naming here a bit weird?
private String environment;
@GetMapping(path = "/auction-started")
public ResponseEntity<String> handleExecutorAddedEvent(@RequestParam("hub.challenge") String challenge) {
reynisson commented 2021-11-14 19:50:49 +00:00 (Migrated from github.com)
Review

Isn't the naming here a bit weird?

Isn't the naming here a bit weird?
public ResponseEntity<String> validateIntent(@RequestParam("hub.challenge") String challenge) {
reynisson commented 2021-11-14 19:50:49 +00:00 (Migrated from github.com)
Review

Isn't the naming here a bit weird?

Isn't the naming here a bit weird?
// Different implementation depending on local development or production
if (environment.equalsIgnoreCase("development")) {
HttpHeaders headers = new HttpHeaders();

reynisson commented 2021-11-14 19:50:49 +00:00 (Migrated from github.com)
Review

Isn't the naming here a bit weird?

Isn't the naming here a bit weird?
reynisson commented 2021-11-14 19:50:49 +00:00 (Migrated from github.com)
Review

Isn't the naming here a bit weird?

Isn't the naming here a bit weird?